| Summary: | bmalloc: Shrink the super chunk size | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, cgarcia, kling, rniwa | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Geoffrey Garen
2015-07-01 11:28:10 PDT
Created attachment 255936 [details]
Patch
Comment on attachment 255936 [details]
Patch
r=me assuming EWS doesn't choke.
Comment on attachment 255936 [details] Patch Attachment 255936 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4779764149649408 New failing tests: fast/css/large-list-of-rules-crash.html Created attachment 255944 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 255936 [details] Patch Attachment 255936 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4714604395495424 New failing tests: fast/css/large-list-of-rules-crash.html Created attachment 255946 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 255972 [details]
Patch
Comment on attachment 255972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255972&action=review > Source/bmalloc/bmalloc/SegregatedFreeList.h:63 > + std::array<FreeList, 17> m_freeLists; Can this be math instead? > > Source/bmalloc/bmalloc/SegregatedFreeList.h:63
> > + std::array<FreeList, 17> m_freeLists;
>
> Can this be math instead?
We need to compute "log base 2 of largeMax minus some other constants". I don't know how to compute the log part at compile time.
Comment on attachment 255972 [details] Patch Clearing flags on attachment: 255972 Committed r186242: <http://trac.webkit.org/changeset/186242> All reviewed patches have been landed. Closing bug. |