Bug 146519

Summary: bmalloc: Shrink the super chunk size
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cgarcia, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
Patch none

Geoffrey Garen
Reported 2015-07-01 11:28:10 PDT
bmalloc: Shrink the super chunk size
Attachments
Patch (1.51 KB, patch)
2015-07-01 11:33 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (567.77 KB, application/zip)
2015-07-01 12:08 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (673.67 KB, application/zip)
2015-07-01 12:11 PDT, Build Bot 		no flags
Details
Patch (1.93 KB, patch)
2015-07-01 16:53 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2015-07-01 11:33:45 PDT
Created attachment 255936 [details] Patch
Andreas Kling
Comment 2 2015-07-01 11:51:59 PDT
Comment on attachment 255936 [details] Patch r=me assuming EWS doesn't choke.
Build Bot
Comment 3 2015-07-01 12:08:24 PDT
Comment on attachment 255936 [details] Patch Attachment 255936 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4779764149649408 New failing tests: fast/css/large-list-of-rules-crash.html
Build Bot
Comment 4 2015-07-01 12:08:27 PDT
Created attachment 255944 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-07-01 12:11:56 PDT
Comment on attachment 255936 [details] Patch Attachment 255936 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4714604395495424 New failing tests: fast/css/large-list-of-rules-crash.html
Build Bot
Comment 6 2015-07-01 12:11:59 PDT
Created attachment 255946 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Geoffrey Garen
Comment 7 2015-07-01 16:53:14 PDT
Created attachment 255972 [details] Patch
Andreas Kling
Comment 8 2015-07-01 17:01:52 PDT
Comment on attachment 255972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255972&action=review > Source/bmalloc/bmalloc/SegregatedFreeList.h:63 > + std::array<FreeList, 17> m_freeLists; Can this be math instead?
Geoffrey Garen
Comment 9 2015-07-02 10:47:48 PDT
> > Source/bmalloc/bmalloc/SegregatedFreeList.h:63 > > + std::array<FreeList, 17> m_freeLists; > > Can this be math instead? We need to compute "log base 2 of largeMax minus some other constants". I don't know how to compute the log part at compile time.
Geoffrey Garen
Comment 10 2015-07-02 16:32:47 PDT
Comment on attachment 255972 [details] Patch Clearing flags on attachment: 255972 Committed r186242: <http://trac.webkit.org/changeset/186242>
Geoffrey Garen
Comment 11 2015-07-02 16:32:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.