Bug 146514

Summary:

Ignore Visual Studio warning in SegmentedVector

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

Web Template Framework

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2015-07-01 09:35:49 PDT

SegmentedVector intentionally has an array of size 0.  This is creating a lot of C4200 warnings making the build logs hard to read and find real errors.  Let's hide this warning locally so we can still find problems elsewhere.

Comment 1 Alex Christensen 2015-07-01 09:37:02 PDT

Created attachment 255924 [details]
Patch

Comment 2 Darin Adler 2015-07-01 09:41:00 PDT

Comment on attachment 255924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255924&action=review

> Source/WTF/wtf/SegmentedVector.h:192
> +#pragma warning(push)
> +#pragma warning(disable: 4200)
>              T entries[0];
> +#pragma warning(pop)

Need to wrap #pragma in appropriate #if.

Comment 3 Alex Christensen 2015-07-01 12:03:43 PDT

Created attachment 255943 [details]
Patch

Comment 4 WebKit Commit Bot 2015-07-01 17:08:49 PDT

Comment on attachment 255943 [details]
Patch

Clearing flags on attachment: 255943

Committed r186207: <http://trac.webkit.org/changeset/186207>

Comment 5 WebKit Commit Bot 2015-07-01 17:08:53 PDT

All reviewed patches have been landed.  Closing bug.