Bug 146503

Summary: [Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit2Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-07-01 00:47:52 PDT 
* SUMMARY
Confusing RetainPtr use in TiledCoreAnimationDrawingArea

* NOTES:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
784:        RetainPtr<CGPathRef> shadowPath = adoptCF(CGPathCreateWithRect(shadowBounds, NULL)).get();

Seems just an adoptCF(...) without the .get() would work. This looks like it might be doing unnecessary work.
Comment 1 Joseph Pecoraro 2015-07-01 00:49:05 PDT 
Created attachment 255907 [details]
[PATCH] Proposed Fix
Comment 2 Tim Horton 2015-07-01 01:04:54 PDT 
Comment on attachment 255907 [details]
[PATCH] Proposed Fix

No idea what I was doing there. Thanks!
Comment 3 Joseph Pecoraro 2015-07-01 01:35:25 PDT 
(In reply to comment #2)
> Comment on attachment 255907 [details]
> [PATCH] Proposed Fix
> 
> No idea what I was doing there. Thanks!

I think it was copied / pasted from other near by code.
Comment 4 WebKit Commit Bot 2015-07-01 01:52:38 PDT 
Comment on attachment 255907 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 255907

Committed r186173: <http://trac.webkit.org/changeset/186173>
Comment 5 WebKit Commit Bot 2015-07-01 01:52:42 PDT 
All reviewed patches have been landed.  Closing bug.