Bug 146503

Summary: [Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit2Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-07-01 00:47:52 PDT
* SUMMARY Confusing RetainPtr use in TiledCoreAnimationDrawingArea * NOTES: WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 784: RetainPtr<CGPathRef> shadowPath = adoptCF(CGPathCreateWithRect(shadowBounds, NULL)).get(); Seems just an adoptCF(...) without the .get() would work. This looks like it might be doing unnecessary work.
Attachments
[PATCH] Proposed Fix (1.64 KB, patch)
2015-07-01 00:49 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-07-01 00:49:05 PDT
Created attachment 255907 [details] [PATCH] Proposed Fix
Tim Horton
Comment 2 2015-07-01 01:04:54 PDT
Comment on attachment 255907 [details] [PATCH] Proposed Fix No idea what I was doing there. Thanks!
Joseph Pecoraro
Comment 3 2015-07-01 01:35:25 PDT
(In reply to comment #2) > Comment on attachment 255907 [details] > [PATCH] Proposed Fix > > No idea what I was doing there. Thanks! I think it was copied / pasted from other near by code.
WebKit Commit Bot
Comment 4 2015-07-01 01:52:38 PDT
Comment on attachment 255907 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255907 Committed r186173: <http://trac.webkit.org/changeset/186173>
WebKit Commit Bot
Comment 5 2015-07-01 01:52:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.