Bug 146503 - [Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
Summary: [Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-01 00:47 PDT by Joseph Pecoraro
Modified: 2015-07-01 01:52 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.64 KB, patch)
2015-07-01 00:49 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-07-01 00:47:52 PDT 
* SUMMARY
Confusing RetainPtr use in TiledCoreAnimationDrawingArea

* NOTES:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
784:        RetainPtr<CGPathRef> shadowPath = adoptCF(CGPathCreateWithRect(shadowBounds, NULL)).get();

Seems just an adoptCF(...) without the .get() would work. This looks like it might be doing unnecessary work.
Comment 1 Joseph Pecoraro 2015-07-01 00:49:05 PDT 
Created attachment 255907 [details]
[PATCH] Proposed Fix
Comment 2 Tim Horton 2015-07-01 01:04:54 PDT 
Comment on attachment 255907 [details]
[PATCH] Proposed Fix

No idea what I was doing there. Thanks!
Comment 3 Joseph Pecoraro 2015-07-01 01:35:25 PDT 
(In reply to comment #2)
> Comment on attachment 255907 [details]
> [PATCH] Proposed Fix
> 
> No idea what I was doing there. Thanks!

I think it was copied / pasted from other near by code.
Comment 4 WebKit Commit Bot 2015-07-01 01:52:38 PDT 
Comment on attachment 255907 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 255907

Committed r186173: <http://trac.webkit.org/changeset/186173>
Comment 5 WebKit Commit Bot 2015-07-01 01:52:42 PDT 
All reviewed patches have been landed.  Closing bug.