Bug 146476

Summary: WKWebView snapshots have the wrong scale after rotation
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Tim Horton 2015-06-30 15:22:00 PDT
WKWebView snapshots have the wrong scale after rotation
Comment 1 Tim Horton 2015-06-30 15:22:26 PDT
Created attachment 255865 [details]
Patch
Comment 2 Tim Horton 2015-06-30 15:23:36 PDT
There are still a lot of weird edge cases with the snapshotting timing, so I'm going to look into having the software snapshot case go through the remote layer tree commit mechanism so that we always get the "right" answer, but if that doesn't work out this patch fixes one of the many bugs.
Comment 3 Tim Horton 2015-07-01 11:43:15 PDT
Created attachment 255938 [details]
Patch
Comment 4 WebKit Commit Bot 2015-07-01 11:45:56 PDT
Attachment 255938 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:216:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2015-07-01 14:36:13 PDT
http://trac.webkit.org/changeset/186194