Bug 146457

Summary: [Win] webViewAddMessageToConsole always gets 1 for isError
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, mkwst, peavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Correct argument to delegate method. zalan: review+

Brent Fulgham
Reported 2015-06-30 09:14:02 PDT
The code that calls the Windows API "webViewAddMessageToConsole" has a hard coded "isError = True" argument. This causes console output on Windows to improperly show errors in the many cases where the log content is informational.
Attachments
Correct argument to delegate method. (1.95 KB, patch)
2015-06-30 09:24 PDT, Brent Fulgham 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-06-30 09:14:31 PDT
<rdar://problem/21606395>
Brent Fulgham
Comment 2 2015-06-30 09:24:43 PDT
Created attachment 255823 [details] Correct argument to delegate method.
Brent Fulgham
Comment 3 2015-06-30 10:34:07 PDT
Committed in r186121. <http://trac.webkit.org/changeset/186121>
Note You need to log in before you can comment on or make changes to this bug.