Bug 146426

Summary: Implementing enumerateDevices
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, jer.noble, jonlee, mdaiter, webkit-bug-importer
Priority: P2 Keywords: HTML5, InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146461, 147903    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Matthew Daiter 2015-06-29 14:51:15 PDT 
Wanted to implement enumerateDevices
Comment 1 Radar WebKit Bug Importer 2015-06-29 14:52:34 PDT 
<rdar://problem/21599847>
Comment 2 Matthew Daiter 2015-08-12 00:47:12 PDT 
Created attachment 258813 [details]
Patch
Comment 3 Matthew Daiter 2015-08-12 14:08:36 PDT 
Created attachment 258845 [details]
Patch
Comment 4 Matthew Daiter 2015-08-12 15:59:32 PDT 
Created attachment 258851 [details]
Patch
Comment 5 Matthew Daiter 2015-08-12 17:37:39 PDT 
Created attachment 258860 [details]
Patch
Comment 6 Matthew Daiter 2015-08-13 11:07:49 PDT 
Created attachment 258901 [details]
Patch
Comment 7 Matthew Daiter 2015-08-13 11:40:57 PDT 
Created attachment 258906 [details]
Patch
Comment 8 Matthew Daiter 2015-08-13 12:55:01 PDT 
Created attachment 258917 [details]
Patch
Comment 9 Matthew Daiter 2015-08-13 13:54:32 PDT 
Created attachment 258929 [details]
Patch
Comment 10 Eric Carlson 2015-08-14 14:26:48 PDT 
Comment on attachment 258929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258929&action=review

> Source/WebCore/platform/mediastream/MediaDevicesPrivate.cpp:32
>  #include "MediaStreamTrackSourcesRequestClient.h"

Nit: this isn't necessary, it is included by the .h file.

> Source/WebCore/platform/mediastream/MediaDevicesPrivate.h:51
> +    const String& requestOrigin() const override { return emptyString(); }

Why an empty string? This needs a FIXME at the very least.
Comment 11 Matthew Daiter 2015-08-14 14:47:18 PDT 
Created attachment 259044 [details]
Patch
Comment 12 WebKit Commit Bot 2015-08-14 15:12:17 PDT 
Comment on attachment 259044 [details]
Patch

Clearing flags on attachment: 259044

Committed r188493: <http://trac.webkit.org/changeset/188493>
Comment 13 WebKit Commit Bot 2015-08-14 15:12:22 PDT 
All reviewed patches have been landed.  Closing bug.