Bug 146426

Summary: Implementing enumerateDevices
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, jer.noble, jonlee, mdaiter, webkit-bug-importer
Priority: P2 Keywords: HTML5, InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146461, 147903    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Matthew Daiter
Reported 2015-06-29 14:51:15 PDT
Wanted to implement enumerateDevices
Attachments
Patch (12.23 KB, patch)
2015-08-12 00:47 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (12.22 KB, patch)
2015-08-12 14:08 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (5.23 KB, patch)
2015-08-12 15:59 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (9.58 KB, patch)
2015-08-12 17:37 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (11.69 KB, patch)
2015-08-13 11:07 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (11.79 KB, patch)
2015-08-13 11:40 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (12.52 KB, patch)
2015-08-13 12:55 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (12.52 KB, patch)
2015-08-13 13:54 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (12.62 KB, patch)
2015-08-14 14:47 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-29 14:52:34 PDT
<rdar://problem/21599847>
Matthew Daiter
Comment 2 2015-08-12 00:47:12 PDT
Created attachment 258813 [details] Patch
Matthew Daiter
Comment 3 2015-08-12 14:08:36 PDT
Created attachment 258845 [details] Patch
Matthew Daiter
Comment 4 2015-08-12 15:59:32 PDT
Created attachment 258851 [details] Patch
Matthew Daiter
Comment 5 2015-08-12 17:37:39 PDT
Created attachment 258860 [details] Patch
Matthew Daiter
Comment 6 2015-08-13 11:07:49 PDT
Created attachment 258901 [details] Patch
Matthew Daiter
Comment 7 2015-08-13 11:40:57 PDT
Created attachment 258906 [details] Patch
Matthew Daiter
Comment 8 2015-08-13 12:55:01 PDT
Created attachment 258917 [details] Patch
Matthew Daiter
Comment 9 2015-08-13 13:54:32 PDT
Created attachment 258929 [details] Patch
Eric Carlson
Comment 10 2015-08-14 14:26:48 PDT
Comment on attachment 258929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258929&action=review > Source/WebCore/platform/mediastream/MediaDevicesPrivate.cpp:32 > #include "MediaStreamTrackSourcesRequestClient.h" Nit: this isn't necessary, it is included by the .h file. > Source/WebCore/platform/mediastream/MediaDevicesPrivate.h:51 > + const String& requestOrigin() const override { return emptyString(); } Why an empty string? This needs a FIXME at the very least.
Matthew Daiter
Comment 11 2015-08-14 14:47:18 PDT
Created attachment 259044 [details] Patch
WebKit Commit Bot
Comment 12 2015-08-14 15:12:17 PDT
Comment on attachment 259044 [details] Patch Clearing flags on attachment: 259044 Committed r188493: <http://trac.webkit.org/changeset/188493>
WebKit Commit Bot
Comment 13 2015-08-14 15:12:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.