Bug 146422

Summary: Crash under _layoutForNodeHighlight: when inspecting espn.com
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: joepeck, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch joepeck: review+

Simon Fraser (smfr)
Reported 2015-06-29 13:39:38 PDT
Crash under _layoutForNodeHighlight: when inspecting espn.com
Attachments
Patch (1.62 KB, patch)
2015-06-29 13:40 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2015-06-29 14:03 PDT, Simon Fraser (smfr) 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-06-29 13:40:34 PDT
Created attachment 255770 [details] Patch
Joseph Pecoraro
Comment 2 2015-06-29 13:48:19 PDT
Comment on attachment 255770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255770&action=review Would be really good to know what type of node we aren't highlighting / getting a quad for. > Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:215 > - (void)_layoutForNodeHighlight:(const Highlight&)highlight WebKit1 has nearly identical code which will need to be updated.
Simon Fraser (smfr)
Comment 3 2015-06-29 14:03:22 PDT
Created attachment 255774 [details] Patch
Joseph Pecoraro
Comment 4 2015-06-29 14:15:59 PDT
Comment on attachment 255774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255774&action=review r=me > Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm:266 > + NSUInteger numLayers = (NSUInteger)h->quads.size(); Not really sure the NSInteger cast is necessary. This could just be: if (!h->quads.size()) {
Simon Fraser (smfr)
Comment 5 2015-06-30 15:01:51 PDT
https://trac.webkit.org/r186134
Note You need to log in before you can comment on or make changes to this bug.