Bug 146396

Summary: REGRESSION (r185915): Source-incompatible change in WKPageUIClient
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar, Regression
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=146249
Attachments:
Description Flags
Renamed callback members back in earlier client versions andersca: review+

mitz
Reported 2015-06-28 08:32:20 PDT
rdar://problem/21581792 http://trac.webkit.org/r185915 changed member names in some older versions of WKPageUIClient, breaking source compatibility.
Attachments
Renamed callback members back in earlier client versions (12.80 KB, patch)
2015-06-28 08:45 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2015-06-28 08:45:18 PDT
Created attachment 255726 [details] Renamed callback members back in earlier client versions
mitz
Comment 2 2015-06-28 09:06:39 PDT
Fixed in <http://trac.webkit.org/r186046>.
Darin Adler
Comment 3 2015-06-28 10:54:36 PDT
Comment on attachment 255726 [details] Renamed callback members back in earlier client versions Some problems compiling PageUIClientEfl.cpp
mitz
Comment 4 2015-06-28 10:58:08 PDT
(In reply to comment #3) > Comment on attachment 255726 [details] > Renamed callback members back in earlier client versions > > Some problems compiling PageUIClientEfl.cpp Tried to fix that in <http://trac.webkit.org/r186048>.
Note You need to log in before you can comment on or make changes to this bug.