Bug 146396

Summary:

REGRESSION (r185915): Source-incompatible change in WKPageUIClient

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar, Regression

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=146249

Attachments:

Description	Flags
Renamed callback members back in earlier client versions	andersca: review+

Description mitz 2015-06-28 08:32:20 PDT

rdar://problem/21581792

http://trac.webkit.org/r185915 changed member names in some older versions of WKPageUIClient, breaking source compatibility.

Comment 1 mitz 2015-06-28 08:45:18 PDT

Created attachment 255726 [details]
Renamed callback members back in earlier client versions

Comment 2 mitz 2015-06-28 09:06:39 PDT

Fixed in <http://trac.webkit.org/r186046>.

Comment 3 Darin Adler 2015-06-28 10:54:36 PDT

Comment on attachment 255726 [details]
Renamed callback members back in earlier client versions

Some problems compiling PageUIClientEfl.cpp

Comment 4 mitz 2015-06-28 10:58:08 PDT

(In reply to comment #3)
> Comment on attachment 255726 [details]
> Renamed callback members back in earlier client versions
> 
> Some problems compiling PageUIClientEfl.cpp

Tried to fix that in <http://trac.webkit.org/r186048>.