Bug 146396 - REGRESSION (r185915): Source-incompatible change in WKPageUIClient
Summary: REGRESSION (r185915): Source-incompatible change in WKPageUIClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: mitz
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2015-06-28 08:32 PDT by mitz
Modified: 2015-06-28 10:58 PDT (History)
0 users

See Also:

Attachments
Renamed callback members back in earlier client versions (12.80 KB, patch)
2015-06-28 08:45 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2015-06-28 08:32:20 PDT 
rdar://problem/21581792

http://trac.webkit.org/r185915 changed member names in some older versions of WKPageUIClient, breaking source compatibility.
Comment 1 mitz 2015-06-28 08:45:18 PDT 
Created attachment 255726 [details]
Renamed callback members back in earlier client versions
Comment 2 mitz 2015-06-28 09:06:39 PDT 
Fixed in <http://trac.webkit.org/r186046>.
Comment 3 Darin Adler 2015-06-28 10:54:36 PDT 
Comment on attachment 255726 [details]
Renamed callback members back in earlier client versions

Some problems compiling PageUIClientEfl.cpp
Comment 4 mitz 2015-06-28 10:58:08 PDT 
(In reply to comment #3)
> Comment on attachment 255726 [details]
> Renamed callback members back in earlier client versions
> 
> Some problems compiling PageUIClientEfl.cpp

Tried to fix that in <http://trac.webkit.org/r186048>.