Summary: | <use> with % lengths does not update on window resize | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jay <jay> | ||||||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | eric, jeffschiller, zimmermann | ||||||||||
Priority: | P2 | Keywords: | HasReduction, Regression | ||||||||||
Version: | 523.x (Safari 3) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
URL: | http://www.peepo.co.uk | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 15124 | ||||||||||||
Attachments: |
|
Description
jay
2007-07-17 06:25:38 PDT
Hi Jay! Thanks for the report, bug confirmed with feature-branch. Greetings, Niko Created attachment 16227 [details]
clip-path example
I have a simpler test case which I'll attach (still not one suitable for DRT however). Created attachment 16400 [details]
simpler test case
This is probably related to bug 14003 (since SVGUseElement uses a RenderSVGContainer) This regressed before Safari 3 shipped. It would be great to make this into a stand-alone test and run bisect-builds on it. I think we have another similar bug in bugzilla. I expect that the layout message is just not getting propagated all the way down. The SVG rendering tree assumes that only if you are set as selfNeedsLayout() then, and only then did your bounds change and thus your kids need to be forced to layout. In the window resize case, that's not always true (due to the way that resize is implemented in the HTML rendering tree). I expect that's what is causing this. This seems to have got very much worse? there is now no resizing at all as the window size is changed. today's nightlies Created attachment 29985 [details]
Another test
I think this is the same bug, bug a maybe an easier test. Start with a small browser window. Resize it larger. In Firefox, it will stay green. In Safari, the new area is blue.
Erics old guess is right, I am working on a fix that should fix all (re-)layouting issues with percentual sized content, in SVG standalone as well as XHTML mixed documents. The peepo testcase is still valid, and I've it fixed locally, expect a patch during the next day(s). Great to hear Nikolas! Does this include Bug 17424? (In reply to comment #11) > Great to hear Nikolas! > > Does this include Bug 17424? Yeah, just tested it, works just fine. Still need to create some new testcases, but in principle the root of the issue is finally fixed. There is still a problem with the peepo website, <symbol> is not yet right. <use> on <use> and friends work great now, I'm aware of the issue and will fix it soon. Created attachment 47150 [details]
Initial patch
Finally peepo.co.uk is fixed :-)
*** Bug 24802 has been marked as a duplicate of this bug. *** Comment on attachment 47150 [details]
Initial patch
r=me
Fixed in r53656. |