Bug 146387

Summary:

Make converting JSString to StringView idiomatically safe

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

New Bugs

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Darin Adler 2015-06-27 09:31:19 PDT

Make converting JSString to StringView idiomatically safe

Comment 1 Darin Adler 2015-06-27 13:51:13 PDT

Created attachment 255704 [details]
Patch

Comment 2 Anders Carlsson 2015-06-27 14:46:38 PDT

Comment on attachment 255704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255704&action=review

> Source/JavaScriptCore/runtime/JSString.h:456
> +    const JSString* volatile m_string { nullptr };

Might be useful to put a comment here stating why this needs to be volatile.

Comment 3 Darin Adler 2015-06-27 15:54:03 PDT

Committed r186037: <http://trac.webkit.org/changeset/186037>