Bug 146387

Summary: Make converting JSString to StringView idiomatically safe
Product: WebKit Reporter: Darin Adler <darin>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Darin Adler
Reported 2015-06-27 09:31:19 PDT
Make converting JSString to StringView idiomatically safe
Attachments
Patch (21.92 KB, patch)
2015-06-27 13:51 PDT, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2015-06-27 13:51:13 PDT
Created attachment 255704 [details] Patch
Anders Carlsson
Comment 2 2015-06-27 14:46:38 PDT
Comment on attachment 255704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255704&action=review > Source/JavaScriptCore/runtime/JSString.h:456 > + const JSString* volatile m_string { nullptr }; Might be useful to put a comment here stating why this needs to be volatile.
Darin Adler
Comment 3 2015-06-27 15:54:03 PDT
Committed r186037: <http://trac.webkit.org/changeset/186037>
Note You need to log in before you can comment on or make changes to this bug.