Bug 146370

Summary:

Media Session: update an element's media session when the 'kind' is updated

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

commit-queue, conrad_shultz, eric.carlson, jer.noble, mrajca, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	none

Description Matt Rajca 2015-06-26 17:32:12 PDT

A media element's media session should be updated when its "kind" is set, changed, or removed.

Comment 1 Radar WebKit Bug Importer 2015-06-26 17:33:59 PDT

<rdar://problem/21575667>

Comment 2 Matt Rajca 2015-06-30 15:11:10 PDT

Created attachment 255863 [details]
Patch

Comment 3 WebKit Commit Bot 2015-06-30 15:14:14 PDT

Attachment 255863 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElement.cpp:6516:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.h:560:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Matt Rajca 2015-07-06 10:33:19 PDT

The 'kind' attribute has been removed from the Media Session in favor of the 'session' attribute.