Bug 146342

Summary:

[EFL] Remove unnecessary overriden methods from ScrollBarEfl

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

146327

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-06-26 03:50:25 PDT

bug146327 is going to remove the invalidate method, which would break 
the EFL build. But we can remove it from ScrollBarEfl now, because they
are exactly same.

Additionally we can remove setFrameRect, setParent and frameRectsChanged too.

Comment 1 Csaba Osztrogonác 2015-06-26 03:51:22 PDT

Created attachment 255628 [details]
Patch

Comment 2 WebKit Commit Bot 2015-06-26 06:06:02 PDT

Comment on attachment 255628 [details]
Patch

Clearing flags on attachment: 255628

Committed r185995: <http://trac.webkit.org/changeset/185995>

Comment 3 WebKit Commit Bot 2015-06-26 06:06:06 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Anders Carlsson 2015-06-26 09:41:41 PDT

Looks like we could just remove all of ScrollbarEfl now?

Comment 5 Csaba Osztrogonác 2015-06-26 09:44:37 PDT

(In reply to comment #4)
> Looks like we could just remove all of ScrollbarEfl now?

I will check it and submit a patch if it is possible.

Comment 6 Csaba Osztrogonác 2015-06-29 03:11:22 PDT

(In reply to comment #5)
> (In reply to comment #4)
> > Looks like we could just remove all of ScrollbarEfl now?
> 
> I will check it and submit a patch if it is possible.

It seems it can be removed, at least bug143566 would like to do it.