Bug 146342

Summary: [EFL] Remove unnecessary overriden methods from ScrollBarEfl
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146327    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-06-26 03:50:25 PDT
bug146327 is going to remove the invalidate method, which would break the EFL build. But we can remove it from ScrollBarEfl now, because they are exactly same. Additionally we can remove setFrameRect, setParent and frameRectsChanged too.
Attachments
Patch (2.27 KB, patch)
2015-06-26 03:51 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-06-26 03:51:22 PDT
Created attachment 255628 [details] Patch
WebKit Commit Bot
Comment 2 2015-06-26 06:06:02 PDT
Comment on attachment 255628 [details] Patch Clearing flags on attachment: 255628 Committed r185995: <http://trac.webkit.org/changeset/185995>
WebKit Commit Bot
Comment 3 2015-06-26 06:06:06 PDT
All reviewed patches have been landed. Closing bug.
Anders Carlsson
Comment 4 2015-06-26 09:41:41 PDT
Looks like we could just remove all of ScrollbarEfl now?
Csaba Osztrogonác
Comment 5 2015-06-26 09:44:37 PDT
(In reply to comment #4) > Looks like we could just remove all of ScrollbarEfl now? I will check it and submit a patch if it is possible.
Csaba Osztrogonác
Comment 6 2015-06-29 03:11:22 PDT
(In reply to comment #5) > (In reply to comment #4) > > Looks like we could just remove all of ScrollbarEfl now? > > I will check it and submit a patch if it is possible. It seems it can be removed, at least bug143566 would like to do it.
Note You need to log in before you can comment on or make changes to this bug.