Bug 146334

Summary: [EFL] Purge unused favicons from IconDatabase after 30 days
Product: WebKit Reporter: Hyungwook Lee <hyungwook.lee>
Component: WebKit EFLAssignee: Hyungwook Lee <hyungwook.lee>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, japhet, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 82346    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Hyungwook Lee
Reported 2015-06-25 17:47:19 PDT
We need purge unused favicons from IconDatabase for database size control.
Attachments
Patch (1.85 KB, patch)
2015-06-25 17:55 PDT, Hyungwook Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hyungwook Lee
Comment 1 2015-06-25 17:55:54 PDT
Created attachment 255604 [details] Patch
Gyuyoung Kim
Comment 2 2015-06-25 20:01:46 PDT
Comment on attachment 255604 [details] Patch I agree with keeping favicons for 30 days as GTK port. LGTM. BTW, it seems there is some missing APIs to support favicon. For example, EFL port needs to support to clear all favicons by EWK APIs. Could you do that ?
Hyungwook Lee
Comment 3 2015-06-25 23:19:53 PDT
I will implement remove all icons API for EFL port soon.
WebKit Commit Bot
Comment 4 2015-06-29 03:10:54 PDT
Comment on attachment 255604 [details] Patch Clearing flags on attachment: 255604 Committed r186068: <http://trac.webkit.org/changeset/186068>
WebKit Commit Bot
Comment 5 2015-06-29 03:10:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.