Bug 146327

Summary:

Get rid of ScrollbarThemeClient now that it's unused

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

146342

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Patch	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Patch	bdakin: review+

Anders Carlsson

Reported 2015-06-25 15:45:00 PDT

Get rid of ScrollbarThemeClient now that it's unused

Attachments
Patch (19.40 KB, patch) 2015-06-25 15:46 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (998.15 KB, application/zip) 2015-06-25 16:34 PDT, Build Bot	no flags	Details
Patch (19.40 KB, patch) 2015-06-26 10:57 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (997.66 KB, application/zip) 2015-06-26 11:45 PDT, Build Bot	no flags	Details
Patch (19.41 KB, patch) 2015-06-26 12:29 PDT, Anders Carlsson	bdakin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2015-06-25 15:46:17 PDT

Created attachment 255581 [details] Patch

Build Bot

Comment 2 2015-06-25 16:34:51 PDT

Comment on attachment 255581 [details] Patch Attachment 255581 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5075377353392128 New failing tests: scrollbars/custom-scrollbars-paint-outside-iframe.html fast/repaint/fixed-right-in-page-scale.html fast/repaint/fixed-move-after-keyboard-scroll.html scrollbars/scrollbar-iframe-click-does-not-blur-content.html fast/css/scrollbar-dynamic-style-change.html fast/frames/unload-reparent-sibling-frame.html scrollbars/scrollbar-scrollbarparts-repaint-crash.html fast/events/scale-and-scroll-iframe-body.html fast/events/scale-and-scroll-window.html scrollbars/scrollbar-drag-thumb-with-large-content.html

Build Bot

Comment 3 2015-06-25 16:34:54 PDT

Created attachment 255595 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Csaba Osztrogonác

Comment 4 2015-06-26 03:53:25 PDT

(In reply to comment #1) > Created attachment 255581 [details] > Patch I fixed the EFL build in bug146342, please don't land this patchbefore bug146342. Thanks.

Anders Carlsson

Comment 5 2015-06-26 10:57:37 PDT

Created attachment 255648 [details] Patch

Build Bot

Comment 6 2015-06-26 11:45:47 PDT

Comment on attachment 255648 [details] Patch Attachment 255648 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5647686845857792 New failing tests: scrollbars/custom-scrollbars-paint-outside-iframe.html fast/repaint/fixed-right-in-page-scale.html fast/repaint/fixed-move-after-keyboard-scroll.html scrollbars/scrollbar-iframe-click-does-not-blur-content.html fast/css/scrollbar-dynamic-style-change.html fast/frames/unload-reparent-sibling-frame.html scrollbars/scrollbar-scrollbarparts-repaint-crash.html fast/events/scale-and-scroll-iframe-body.html fast/events/scale-and-scroll-window.html scrollbars/scrollbar-drag-thumb-with-large-content.html

Build Bot

Comment 7 2015-06-26 11:45:49 PDT

Created attachment 255654 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Anders Carlsson

Comment 8 2015-06-26 12:29:08 PDT

Created attachment 255658 [details] Patch

Anders Carlsson

Comment 9 2015-06-26 13:43:28 PDT

Committed r186007: <http://trac.webkit.org/changeset/186007>

Note You need to log in before you can comment on or make changes to this bug.