Bug 146280

Summary: Improve JSDOMPromise callPromiseFunction naming
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2015-06-24 08:33:57 PDT 
Following on bug 146060, we could do some improvements.

>> Source/WebCore/bindings/js/JSDOMPromise.h:62
>> +template<class JSClassName>
>
>The type here is the JavaScript class, not the JavaScript class name. I suggest the name WrapperClass here instead of JSClassName. Also, we almost always use typename rather >than class in templates, although I’m not entirely sure why.
>
>> Source/WebCore/bindings/js/JSDOMPromise.h:63
>> +inline JSC::JSValue callPromiseFunction(JSC::ExecState& state, JSClassName& jsObject, JSC::EncodedJSValue promiseFunction(JSC::ExecState*, JSClassName*, >JSC::JSPromiseDeferred*))
>
>A typical name used in bindings for what we are calling jsObject here is “wrapper”
Comment 1 youenn fablet 2015-06-24 08:37:01 PDT 
Created attachment 255483 [details]
Patch
Comment 2 youenn fablet 2015-06-24 08:38:38 PDT 
Given the modifications are already suggested as part of a review, I do not think a review is needed. But just in case, I will wait for tomorrow to cq it.
Comment 3 WebKit Commit Bot 2015-06-24 12:08:59 PDT 
Comment on attachment 255483 [details]
Patch

Clearing flags on attachment: 255483

Committed r185919: <http://trac.webkit.org/changeset/185919>
Comment 4 WebKit Commit Bot 2015-06-24 12:09:03 PDT 
All reviewed patches have been landed.  Closing bug.