Bug 146255

Summary: Add operator! and copy/move constructors to WeakObjCPtr
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2015-06-23 15:39:56 PDT
Add operator! and copy/move constructors to WeakObjCPtr
Attachments
Patch (3.87 KB, patch)
2015-06-23 15:43 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-06-23 15:43:50 PDT
Created attachment 255442 [details] Patch
Andreas Kling
Comment 2 2015-06-23 15:45:29 PDT
Comment on attachment 255442 [details] Patch r=me Nice test.
WebKit Commit Bot
Comment 3 2015-06-23 15:46:30 PDT
Attachment 255442 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:40: objc_copyWeak is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:41: objc_moveWeak is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2015-06-23 15:47:41 PDT
Committed r185887: <http://trac.webkit.org/changeset/185887>
Note You need to log in before you can comment on or make changes to this bug.