Bug 146253

Summary: MediaSession: Support setting of metadata
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: conrad_shultz, eric.carlson, jer.noble, mrajca, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch eric.carlson: review+

Description Matt Rajca 2015-06-23 15:31:20 PDT
The MediaSession.setMetadata method needs to be implemented as described in section 5.1.3 of the Media Session spec.
Comment 1 Radar WebKit Bug Importer 2015-06-23 15:32:18 PDT
<rdar://problem/21512861>
Comment 2 Matt Rajca 2015-06-23 18:25:49 PDT
Created attachment 255464 [details]
Patch
Comment 3 Eric Carlson 2015-06-24 08:34:49 PDT
Comment on attachment 255464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255464&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:39
> +    : m_scriptExecutionContext(&context)

Unless you will need the ScriptExecutionContext for something else later, I think we should capture a reference to the document instead as the only thing we do with the ScriptExecutionContext is get its document.
Comment 4 Matt Rajca 2015-06-24 09:40:31 PDT
Committed r185914: <http://trac.webkit.org/changeset/185914>
Comment 5 Matt Rajca 2015-06-24 09:40:57 PDT
(In reply to comment #3)
> Comment on attachment 255464 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255464&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:39
> > +    : m_scriptExecutionContext(&context)
> 
> Unless you will need the ScriptExecutionContext for something else later, I
> think we should capture a reference to the document instead as the only
> thing we do with the ScriptExecutionContext is get its document.

Changed. Thanks!