Bug 146252

Summary: Should reduce tile coverage for the first paint after a tab switch
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andreas Kling 2015-06-23 15:26:25 PDT 
<rdar://problem/19821583>
Comment 1 Andreas Kling 2015-06-23 15:38:52 PDT 
Created attachment 255441 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-06-23 15:49:14 PDT 
Comment on attachment 255441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255441&action=review

> Source/WebCore/page/FrameView.cpp:2496
> +    // Turn off speculative tiling for a brief moment after a FrameView appears on screen.
> +    // Note that adjustTiledBackingCoverage() kicks the (500ms) timer to re-enable it.
> +    m_speculativeTilingEnabled = false;
> +    m_wasScrolledByUser = false;
> +    adjustTiledBackingCoverage();

Do you want to do this for non-main FrameViews?
Comment 3 Andreas Kling 2015-06-23 16:01:09 PDT 
(In reply to comment #2)
> Comment on attachment 255441 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255441&action=review
> 
> > Source/WebCore/page/FrameView.cpp:2496
> > +    // Turn off speculative tiling for a brief moment after a FrameView appears on screen.
> > +    // Note that adjustTiledBackingCoverage() kicks the (500ms) timer to re-enable it.
> > +    m_speculativeTilingEnabled = false;
> > +    m_wasScrolledByUser = false;
> > +    adjustTiledBackingCoverage();
> 
> Do you want to do this for non-main FrameViews?

Ah, good point. We shouldn't do this for non-main FrameViews.
Comment 4 Andreas Kling 2015-06-23 16:02:04 PDT 
Created attachment 255445 [details]
Patch

Only do this for the main FrameView.
Comment 5 WebKit Commit Bot 2015-06-23 19:10:14 PDT 
Comment on attachment 255445 [details]
Patch

Clearing flags on attachment: 255445

Committed r185897: <http://trac.webkit.org/changeset/185897>
Comment 6 WebKit Commit Bot 2015-06-23 19:10:23 PDT 
All reviewed patches have been landed.  Closing bug.