Bug 146251 – Media controls are missing the white backdrop in UIWebViews

• Component: New Bugs
• Status: RESOLVED FIXED

[Dean Jackson]

Media controls are missing the white backdrop in UIWebViews

[Dean Jackson]

<rdar://problem/20181345>

[Dean Jackson]

Created attachment 255439 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 255439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255439&action=review

> Source/WebCore/platform/graphics/ca/cocoa/WebSystemBackdropLayer.mm:65
> +- (void)setBackgroundColor:(CGColorRef)backgroundColor
> +{
> +    UNUSED_PARAM(backgroundColor);
> +    static CGColorRef layerBackgroundColor;
> +    if (!layerBackgroundColor) {
> +        CGFloat components[4] = { 0.8, 0.8, 0.8, 0.8 };
> +        layerBackgroundColor = CGColorCreate(cachedCGColorSpace(ColorSpaceSRGB), components);
> +        [super setBackgroundColor:layerBackgroundColor];
> +    }
> +}

Seems odd to override -setBackgroundColor: and replace the color. Why not just set the background color in -init, and make sure no clients push a background color?

[Dean Jackson]

Created attachment 255440 [details]
Patch

[Dean Jackson]

Committed r185888: <http://trac.webkit.org/changeset/185888>