Bug 146251 - Media controls are missing the white backdrop in UIWebViews
Summary: Media controls are missing the white backdrop in UIWebViews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-23 15:09 PDT by Dean Jackson
Modified: 2015-06-23 15:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.08 KB, patch)
2015-06-23 15:14 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (12.93 KB, patch)
2015-06-23 15:31 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-06-23 15:09:57 PDT 
Media controls are missing the white backdrop in UIWebViews
Comment 1 Dean Jackson 2015-06-23 15:13:29 PDT 
<rdar://problem/20181345>
Comment 2 Dean Jackson 2015-06-23 15:14:28 PDT 
Created attachment 255439 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-06-23 15:27:09 PDT 
Comment on attachment 255439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255439&action=review

> Source/WebCore/platform/graphics/ca/cocoa/WebSystemBackdropLayer.mm:65
> +- (void)setBackgroundColor:(CGColorRef)backgroundColor
> +{
> +    UNUSED_PARAM(backgroundColor);
> +    static CGColorRef layerBackgroundColor;
> +    if (!layerBackgroundColor) {
> +        CGFloat components[4] = { 0.8, 0.8, 0.8, 0.8 };
> +        layerBackgroundColor = CGColorCreate(cachedCGColorSpace(ColorSpaceSRGB), components);
> +        [super setBackgroundColor:layerBackgroundColor];
> +    }
> +}

Seems odd to override -setBackgroundColor: and replace the color. Why not just set the background color in -init, and make sure no clients push a background color?
Comment 4 Dean Jackson 2015-06-23 15:31:54 PDT 
Created attachment 255440 [details]
Patch
Comment 5 Dean Jackson 2015-06-23 15:48:32 PDT 
Committed r185888: <http://trac.webkit.org/changeset/185888>