Bug 146202

Summary: REGRESSION(r182303): [GTK] Context menu API is broken since r182303
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, csaavedra, gustavo, mcatanzaro, mrobinson, pnormand, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2015-06-22 05:06:27 PDT
And we didn't notice it because context menu API tests are skipped (see https://bugs.webkit.org/show_bug.cgi?id=117689). The problem is that ContextMenuclient API changed in r182303, but we didn't notice it either, and the default handler for getContextMenuFromProposedMenu was executed. An override keyword would have caught this.
Attachments
Patch (2.73 KB, patch)
2015-06-22 05:08 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-06-22 05:08:44 PDT
Created attachment 255343 [details] Patch
WebKit Commit Bot
Comment 2 2015-06-22 05:10:46 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2015-06-22 05:43:26 PDT
Committed r185825: <http://trac.webkit.org/changeset/185825>
Note You need to log in before you can comment on or make changes to this bug.