Bug 146197

Summary:

[Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox Profiles target

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, dbates, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Part 1: prepare the Sandbox Profiles target	andersca: review+

Description mitz 2015-06-21 22:40:50 PDT

We don’t need to maintain a separate build target for installing the sandbox profiles into the override location.

Comment 1 mitz 2015-06-21 22:45:28 PDT

Created attachment 255338 [details]
Part 1: prepare the Sandbox Profiles target

Comment 2 Daniel Bates 2015-06-22 09:28:57 PDT

Comment on attachment 255338 [details]
Part 1: prepare the Sandbox Profiles target

View in context: https://bugs.webkit.org/attachment.cgi?id=255338&action=review

> Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1
> +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES));

I take it you meant to write "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of "INSTALL_PATH_ENGINEERING_BUILD_".

Comment 3 mitz 2015-06-22 09:30:18 PDT

(In reply to comment #2)
> Comment on attachment 255338 [details]
> Part 1: prepare the Sandbox Profiles target
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255338&action=review
> 
> > Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1
> > +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES));
> 
> I take it you meant to write
> "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of
> "INSTALL_PATH_ENGINEERING_BUILD_".

Good catch! Thank you.

Comment 4 mitz 2015-06-22 10:05:31 PDT

Committed attachment 255338 [details] in <http://trac.webkit.org/r185832>.

Comment 5 mitz 2015-06-22 21:11:45 PDT

Deleted the target in <http://trac.webkit.org/r185861>.