Bug 146166

Summary:

Selection services cannot be invoked when force click is enabled

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, beidson, enrica, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Tim Horton 2015-06-19 15:13:22 PDT

Selection services cannot be invoked when force click is enabled

Comment 1 Tim Horton 2015-06-19 15:13:41 PDT

Created attachment 255233 [details]
Patch

Comment 2 Darin Adler 2015-06-19 16:25:22 PDT

Comment on attachment 255233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255233&action=review

> Source/WebCore/page/mac/ServicesOverlayController.h:72
> +            TelephoneNumberType = 1 << 1,
> +            SelectionType = 1 << 2,

Why skip 1 << 0?

> Source/WebCore/page/mac/ServicesOverlayController.h:74
> +        typedef uint32_t Type;

Hmm, 32 bits to hold 2 bits. I guess that’s OK.

Comment 3 Tim Horton 2015-06-19 16:41:39 PDT

http://trac.webkit.org/changeset/185778