Bug 146166

Summary: Selection services cannot be invoked when force click is enabled
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, enrica, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Tim Horton
Reported 2015-06-19 15:13:22 PDT
Selection services cannot be invoked when force click is enabled
Attachments
Patch (15.67 KB, patch)
2015-06-19 15:13 PDT, Tim Horton 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-06-19 15:13:41 PDT
Created attachment 255233 [details] Patch
Darin Adler
Comment 2 2015-06-19 16:25:22 PDT
Comment on attachment 255233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255233&action=review > Source/WebCore/page/mac/ServicesOverlayController.h:72 > + TelephoneNumberType = 1 << 1, > + SelectionType = 1 << 2, Why skip 1 << 0? > Source/WebCore/page/mac/ServicesOverlayController.h:74 > + typedef uint32_t Type; Hmm, 32 bits to hold 2 bits. I guess that’s OK.
Tim Horton
Comment 3 2015-06-19 16:41:39 PDT
http://trac.webkit.org/changeset/185778
Note You need to log in before you can comment on or make changes to this bug.