Bug 146166 - Selection services cannot be invoked when force click is enabled
Summary: Selection services cannot be invoked when force click is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-19 15:13 PDT by Tim Horton
Modified: 2015-06-19 16:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.67 KB, patch)
2015-06-19 15:13 PDT, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-06-19 15:13:22 PDT 
Selection services cannot be invoked when force click is enabled
Comment 1 Tim Horton 2015-06-19 15:13:41 PDT 
Created attachment 255233 [details]
Patch
Comment 2 Darin Adler 2015-06-19 16:25:22 PDT 
Comment on attachment 255233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255233&action=review

> Source/WebCore/page/mac/ServicesOverlayController.h:72
> +            TelephoneNumberType = 1 << 1,
> +            SelectionType = 1 << 2,

Why skip 1 << 0?

> Source/WebCore/page/mac/ServicesOverlayController.h:74
> +        typedef uint32_t Type;

Hmm, 32 bits to hold 2 bits. I guess that’s OK.
Comment 3 Tim Horton 2015-06-19 16:41:39 PDT 
http://trac.webkit.org/changeset/185778