Bug 146141

Summary:

Web Inspector: Avoid getOwnPropertyNames/Symbols on very large lists

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-06-18 22:49:44 PDT

* SUMMARY
Avoid getOwnPropertyNames/Symbols on very large lists.

Note that better handling of large lists in general should be handled by:
<https://webkit.org/b/143589> Web Inspector: Better handling for large collections in Object Trees

For now, lets not hang / out of memory trying to build a list of all the property names in a multi-million element list.

* STEPS TO REPRODUCE
1. js> var buffer = new ArrayBuffer(10000000); var int8View = new Int8Array(buffer); int8View
  => hang (Web Content Process's memory grows, attempting to get property names for a preview)
2. js> var buffer = new ArrayBuffer(10000000); var int8View = new Int8Array(buffer);
3. Type: "int8View."
  => hang (Web Content Process's memory grows, attempting to get property names for autocompletion)

Comment 1 Joseph Pecoraro 2015-06-18 22:56:55 PDT

<rdar://problem/21233251>

Comment 2 Joseph Pecoraro 2015-06-18 22:57:48 PDT

Created attachment 255175 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2015-06-19 01:06:37 PDT

Comment on attachment 255175 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 255175

Committed r185741: <http://trac.webkit.org/changeset/185741>

Comment 4 WebKit Commit Bot 2015-06-19 01:06:42 PDT

All reviewed patches have been landed.  Closing bug.