Bug 146112

Summary: ~4% Membuster regression after WebKit r185452
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, kling
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146544    
Bug Blocks:    
Attachments:
Description Flags
patch cdumez: review+

Antti Koivisto
Reported 2015-06-18 08:34:20 PDT
Looks like delaying writes in disk cache increased memory consumption in Membuster, probably due to keeping write buffers around longer.
Attachments
patch (4.78 KB, patch)
2015-06-18 09:24 PDT, Antti Koivisto 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-06-18 09:24:45 PDT
Created attachment 255118 [details] patch
Antti Koivisto
Comment 2 2015-06-18 09:25:13 PDT
rdar://problem/21406677
Chris Dumez
Comment 3 2015-06-18 09:34:54 PDT
Comment on attachment 255118 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=255118&action=review r=me > Source/WebKit2/ChangeLog:8 > + Clear the cache write queue on critical memory pressure. There can be substantial amount of memory there and we I thought you were going to hurry the writes instead but why not. This is much simpler :) > Source/WebKit2/NetworkProcess/NetworkProcess.cpp:184 > + nit: Seems unnecessary to add a line here.
Antti Koivisto
Comment 4 2015-06-18 10:17:47 PDT
https://trac.webkit.org/r185704
WebKit Commit Bot
Comment 5 2015-07-02 05:11:01 PDT
Re-opened since this is blocked by bug 146544
Note You need to log in before you can comment on or make changes to this bug.