Bug 146097

Summary: Remove redundant chromium bug macro
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ossy: review+

Gyuyoung Kim
Reported 2015-06-17 20:27:11 PDT
We don't need to keep BUGCR keyword for TestExpectations anymore.
Attachments
Patch (2.27 KB, patch)
2015-06-17 20:28 PDT, Gyuyoung Kim 		ossy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-06-17 20:28:04 PDT
Created attachment 255081 [details] Patch
Csaba Osztrogonác
Comment 2 2015-06-18 02:20:24 PDT
Comment on attachment 255081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255081&action=review LGTM > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:151 > - expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') > + expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') Please remove BUGV8 too before landing.
Gyuyoung Kim
Comment 3 2015-06-18 02:23:32 PDT
Committed r185698: <http://trac.webkit.org/changeset/185698>
Gyuyoung Kim
Comment 4 2015-06-18 02:23:55 PDT
(In reply to comment #2) > Comment on attachment 255081 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255081&action=review > > LGTM > > > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:151 > > - expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') > > + expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.') > > Please remove BUGV8 too before landing. Done !
Note You need to log in before you can comment on or make changes to this bug.