Bug 146097 - Remove redundant chromium bug macro
Summary: Remove redundant chromium bug macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-17 20:27 PDT by Gyuyoung Kim
Modified: 2015-06-18 02:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2015-06-17 20:28 PDT, Gyuyoung Kim 		ossy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-06-17 20:27:11 PDT 
We don't need to keep BUGCR keyword for TestExpectations anymore.
Comment 1 Gyuyoung Kim 2015-06-17 20:28:04 PDT 
Created attachment 255081 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-06-18 02:20:24 PDT 
Comment on attachment 255081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255081&action=review

LGTM

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:151
> -                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.')
> +                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.')

Please remove BUGV8 too before landing.
Comment 3 Gyuyoung Kim 2015-06-18 02:23:32 PDT 
Committed r185698: <http://trac.webkit.org/changeset/185698>
Comment 4 Gyuyoung Kim 2015-06-18 02:23:55 PDT 
(In reply to comment #2)
> Comment on attachment 255081 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255081&action=review
> 
> LGTM
> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:151
> > -                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.')
> > +                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.')
> 
> Please remove BUGV8 too before landing.

Done !