Bug 146080

Summary: Web Inspector: Fix shape-highlight layout tests
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2015-06-17 15:04:18 PDT 
Currently, the tests in LayoutTests/inspector/dom/ are failing with unknown errors.  These fixes are expecting the changes in https://bugs.webkit.org/show_bug.cgi?id=145658 to be made.
Comment 1 Devin Rousso 2015-06-17 15:08:40 PDT 
Created attachment 255040 [details]
Patch
Comment 2 Joseph Pecoraro 2015-06-17 15:09:44 PDT 
Comment on attachment 255040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255040&action=review

> Source/WebCore/inspector/InspectorOverlay.cpp:668
> -            shapeObject->setMarginShape(shapePath.copyRef());
> +            shapeObject->setMarginShape(marginShapePath.copyRef());

Yay!

> LayoutTests/http/tests/inspector/dom/shapes-test.js:35
> +            InspectorTest.assert(!error, "When evaluating code, received unexpected error:" + error);
> +            InspectorTest.assert(!error, "When evaluating code, an exception was thrown:" + wasThrown);

Missing LayoutTests/ChangeLog entry for the updates to this file. r- so you can add a changelog. Otherwise the patch looks great!
Comment 3 Devin Rousso 2015-06-17 15:19:43 PDT 
Created attachment 255041 [details]
Patch
Comment 4 Joseph Pecoraro 2015-06-17 15:23:54 PDT 
Comment on attachment 255041 [details]
Patch

r=me
Comment 5 Radar WebKit Bug Importer 2015-07-09 13:35:46 PDT 
<rdar://problem/21752788>
Comment 6 WebKit Commit Bot 2015-07-09 13:36:01 PDT 
Comment on attachment 255041 [details]
Patch

Rejecting attachment 255041 [details] from commit-queue.

drousso@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 WebKit Commit Bot 2015-07-09 15:08:58 PDT 
Comment on attachment 255041 [details]
Patch

Clearing flags on attachment: 255041

Committed r186639: <http://trac.webkit.org/changeset/186639>
Comment 8 WebKit Commit Bot 2015-07-09 15:09:02 PDT 
All reviewed patches have been landed.  Closing bug.