Bug 146034 – Move LocalStorageDetails into the local storage database tracker

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Move LocalStorageDetails into the local storage database tracker

[Anders Carlsson]

Created attachment 254973 [details]
Patch

[WebKit Commit Bot]

Attachment 254973 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:626:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 254973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254973&action=review

r=me

> Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp:130
> -    storageManager->deleteAllLocalStorageEntries();
> +    storageManager->deleteLocalStorageOriginsModifiedSince(std::chrono::system_clock::time_point::min(), [] { });

The old version read slightly nicer :|

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.h:68
> +    Vector<OriginDetails> originDetails();

const?

[Anders Carlsson]

Committed r185625: <http://trac.webkit.org/changeset/185625>