Bug 146034

Summary: Move LocalStorageDetails into the local storage database tracker
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Anders Carlsson 2015-06-16 16:03:13 PDT
Move LocalStorageDetails into the local storage database tracker
Comment 1 Anders Carlsson 2015-06-16 16:09:41 PDT
Created attachment 254973 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-16 16:10:47 PDT
Attachment 254973 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:626:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-06-16 16:13:48 PDT
Comment on attachment 254973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254973&action=review

r=me

> Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp:130
> -    storageManager->deleteAllLocalStorageEntries();
> +    storageManager->deleteLocalStorageOriginsModifiedSince(std::chrono::system_clock::time_point::min(), [] { });

The old version read slightly nicer :|

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.h:68
> +    Vector<OriginDetails> originDetails();

const?
Comment 4 Anders Carlsson 2015-06-16 16:31:28 PDT
Committed r185625: <http://trac.webkit.org/changeset/185625>