Bug 146027

Summary: WebResourceCacheManager is unused, get rid of it
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, clopez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Anders Carlsson 2015-06-16 13:39:08 PDT
WebResourceCacheManager is unused, get rid of it
Comment 1 Anders Carlsson 2015-06-16 13:42:18 PDT
Created attachment 254967 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-16 14:55:47 PDT
Comment on attachment 254967 [details]
Patch

Clearing flags on attachment: 254967

Committed r185615: <http://trac.webkit.org/changeset/185615>
Comment 3 WebKit Commit Bot 2015-06-16 14:55:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Carlos Alberto Lopez Perez 2015-06-16 17:39:13 PDT
This was used by the GTK port in webkit_web_context_clear_cache() at Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp

Now the GTK build is broken :(

I don't think is so hard to use a tool like grep in order to check no other ports are using the code you are removing, isn't it?
Comment 5 Anders Carlsson 2015-06-16 17:43:28 PDT
(In reply to comment #4)
> This was used by the GTK port in webkit_web_context_clear_cache() at
> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
> 
> Now the GTK build is broken :(
> 
> I don't think is so hard to use a tool like grep in order to check no other
> ports are using the code you are removing, isn't it?

https://lists.webkit.org/pipermail/webkit-dev/2013-January/023255.html
Comment 6 Anders Carlsson 2015-06-16 17:48:50 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > This was used by the GTK port in webkit_web_context_clear_cache() at
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
> > 
> > Now the GTK build is broken :(
> > 
> > I don't think is so hard to use a tool like grep in order to check no other
> > ports are using the code you are removing, isn't it?
> 
> https://lists.webkit.org/pipermail/webkit-dev/2013-January/023255.html

(You can easily reimplement the webkit_web_context_clear_cache functionality in terms of WebsiteDataStore).
Comment 7 Carlos Alberto Lopez Perez 2015-06-16 19:21:25 PDT
Landed quick build fix on https://trac.webkit.org/r185634 and opened bug 146041 for bringing back the functionality.