Bug 146016

Summary: [EFL] test_ewk2_application_cache_manager has been failed since r185527
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hyungwook.lee, lucas.de.marchi, ossy, piorkowskiprzemyslaw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 132813    
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-06-16 06:13:53 PDT
SSIA.
Attachments
Patch (1.59 KB, patch)
2015-06-20 08:17 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (4.92 KB, patch)
2015-07-01 13:04 PDT, Przemyslaw Piorkowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-06-20 08:14:28 PDT
r185527 changed WebApplicationCacheManagerProxy with WebsiteDataRecord. However this change didn't work on EFL port. I guess that EFL port needs to support port specific implementation. It needs to spend days to support it or find what is problem. To maintain EFL API test, I would like to disable this test for a while.
Gyuyoung Kim
Comment 2 2015-06-20 08:17:27 PDT
Created attachment 255290 [details] Patch
Csaba Osztrogonác
Comment 3 2015-06-22 00:50:25 PDT
Comment on attachment 255290 [details] Patch rs=me, please leaave this bug open until the proper fix is landed.
Gyuyoung Kim
Comment 4 2015-06-22 02:34:23 PDT
(In reply to comment #3) > Comment on attachment 255290 [details] > Patch > > rs=me, please leaave this bug open until the proper fix is landed. Ok, let's open this bug until we find proper solution.
Gyuyoung Kim
Comment 5 2015-06-22 03:04:19 PDT
Comment on attachment 255290 [details] Patch Clearing flags on attachment: 255290 Committed r185822: <http://trac.webkit.org/changeset/185822>
Gyuyoung Kim
Comment 6 2015-06-22 03:04:25 PDT
All reviewed patches have been landed. Closing bug.
Gyuyoung Kim
Comment 7 2015-06-22 03:05:30 PDT
We keep to open this bug until finding a proper solution.
Przemyslaw Piorkowski
Comment 8 2015-07-01 13:04:17 PDT
Created attachment 255948 [details] Patch
Przemyslaw Piorkowski
Comment 9 2015-07-01 14:41:15 PDT
It seems that I've found fix for this bug. Core issue was lack of PUBLIC_SUFFIX_LIST option which was needed to get display name for security origin. Due to fact that GTK also recently needed this feature to enable (https://bugs.webkit.org/show_bug.cgi?id=146318) they implemented soup version of PUBLIC_SUFFIX_LIST which works also for EFL port.
Gyuyoung Kim
Comment 10 2015-07-02 17:39:36 PDT
Comment on attachment 255948 [details] Patch LGTM. r=me.
WebKit Commit Bot
Comment 11 2015-07-02 20:09:44 PDT
Comment on attachment 255948 [details] Patch Clearing flags on attachment: 255948 Committed r186255: <http://trac.webkit.org/changeset/186255>
WebKit Commit Bot
Comment 12 2015-07-02 20:09:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.