| Summary: | [EFL] test_ewk2_application_cache_manager has been failed since r185527 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, hyungwook.lee, lucas.de.marchi, ossy, piorkowskiprzemyslaw | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 132813 | ||||||||
| Attachments: |
|
||||||||
|
Description
Gyuyoung Kim
2015-06-16 06:13:53 PDT
r185527 changed WebApplicationCacheManagerProxy with WebsiteDataRecord. However this change didn't work on EFL port. I guess that EFL port needs to support port specific implementation. It needs to spend days to support it or find what is problem. To maintain EFL API test, I would like to disable this test for a while. Created attachment 255290 [details]
Patch
Comment on attachment 255290 [details]
Patch
rs=me, please leaave this bug open until the proper fix is landed.
(In reply to comment #3) > Comment on attachment 255290 [details] > Patch > > rs=me, please leaave this bug open until the proper fix is landed. Ok, let's open this bug until we find proper solution. Comment on attachment 255290 [details] Patch Clearing flags on attachment: 255290 Committed r185822: <http://trac.webkit.org/changeset/185822> All reviewed patches have been landed. Closing bug. We keep to open this bug until finding a proper solution. Created attachment 255948 [details]
Patch
It seems that I've found fix for this bug. Core issue was lack of PUBLIC_SUFFIX_LIST option which was needed to get display name for security origin. Due to fact that GTK also recently needed this feature to enable (https://bugs.webkit.org/show_bug.cgi?id=146318) they implemented soup version of PUBLIC_SUFFIX_LIST which works also for EFL port. Comment on attachment 255948 [details]
Patch
LGTM. r=me.
Comment on attachment 255948 [details] Patch Clearing flags on attachment: 255948 Committed r186255: <http://trac.webkit.org/changeset/186255> All reviewed patches have been landed. Closing bug. |