Bug 146016 - [EFL] test_ewk2_application_cache_manager has been failed since r185527
Summary: [EFL] test_ewk2_application_cache_manager has been failed since r185527
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 132813
  Show dependency treegraph
 
Reported: 2015-06-16 06:13 PDT by Gyuyoung Kim
Modified: 2015-07-02 20:09 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2015-06-20 08:17 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (4.92 KB, patch)
2015-07-01 13:04 PDT, Przemyslaw Piorkowski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-06-16 06:13:53 PDT
SSIA.
Comment 1 Gyuyoung Kim 2015-06-20 08:14:28 PDT
r185527 changed WebApplicationCacheManagerProxy with WebsiteDataRecord. However this change didn't work on EFL port. I guess that EFL port needs to support port specific implementation. It needs to spend days to support it or find what is problem. To maintain EFL API test, I would like to disable this test for a while.
Comment 2 Gyuyoung Kim 2015-06-20 08:17:27 PDT
Created attachment 255290 [details]
Patch
Comment 3 Csaba Osztrogonác 2015-06-22 00:50:25 PDT
Comment on attachment 255290 [details]
Patch

rs=me, please leaave this bug open until the proper fix is landed.
Comment 4 Gyuyoung Kim 2015-06-22 02:34:23 PDT
(In reply to comment #3)
> Comment on attachment 255290 [details]
> Patch
> 
> rs=me, please leaave this bug open until the proper fix is landed.

Ok, let's open this bug until we find proper solution.
Comment 5 Gyuyoung Kim 2015-06-22 03:04:19 PDT
Comment on attachment 255290 [details]
Patch

Clearing flags on attachment: 255290

Committed r185822: <http://trac.webkit.org/changeset/185822>
Comment 6 Gyuyoung Kim 2015-06-22 03:04:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Gyuyoung Kim 2015-06-22 03:05:30 PDT
We keep to open this bug until finding a proper solution.
Comment 8 Przemyslaw Piorkowski 2015-07-01 13:04:17 PDT
Created attachment 255948 [details]
Patch
Comment 9 Przemyslaw Piorkowski 2015-07-01 14:41:15 PDT
It seems that I've found fix for this bug. Core issue was lack of PUBLIC_SUFFIX_LIST option which was needed to get display name for security origin. Due to fact that GTK also recently needed this feature to enable (https://bugs.webkit.org/show_bug.cgi?id=146318) they implemented soup version of PUBLIC_SUFFIX_LIST which works also for EFL port.
Comment 10 Gyuyoung Kim 2015-07-02 17:39:36 PDT
Comment on attachment 255948 [details]
Patch

LGTM. r=me.
Comment 11 WebKit Commit Bot 2015-07-02 20:09:44 PDT
Comment on attachment 255948 [details]
Patch

Clearing flags on attachment: 255948

Committed r186255: <http://trac.webkit.org/changeset/186255>
Comment 12 WebKit Commit Bot 2015-07-02 20:09:54 PDT
All reviewed patches have been landed.  Closing bug.