Bug 146005

Summary: Add test expectations for El Capitan
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, mkwst, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch mitz: review+

Alexey Proskuryakov
Reported 2015-06-15 22:05:44 PDT
Add test expectations and most tools code. What's left out is WebKitSystemInterface and LLVM binaries support.
Attachments
proposed patch (815.84 KB, patch)
2015-06-15 22:12 PDT, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-06-15 22:12:41 PDT
Created attachment 254934 [details] proposed patch
mitz
Comment 2 2015-06-15 22:25:47 PDT
Comment on attachment 254934 [details] proposed patch I looked briefly at the tools changes and they seemed sane. rs=me
Alexey Proskuryakov
Comment 3 2015-06-15 22:48:37 PDT
Committed <http://trac.webkit.org/r185581>.
Tim Horton
Comment 4 2015-08-28 18:56:26 PDT
Comment on attachment 254934 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=254934&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:212 > + 'Mac', 'SnowLeopard', 'Lion', 'MountainLion', 'Mavericks', 'Yosemite', 'ElCapitan' There's a missing comma at the end of the line here. How is this not causing more trouble?
Tim Horton
Comment 5 2015-08-28 18:58:44 PDT
(In reply to comment #4) > Comment on attachment 254934 [details] > proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254934&action=review > > > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:212 > > + 'Mac', 'SnowLeopard', 'Lion', 'MountainLion', 'Mavericks', 'Yosemite', 'ElCapitan' > > There's a missing comma at the end of the line here. How is this not causing > more trouble? Fixed in http://trac.webkit.org/changeset/189137
Note You need to log in before you can comment on or make changes to this bug.