Bug 145963

Summary: [ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, darin, fpizlo, ggaren, kling, mark.lam, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Yusuke Suzuki
Reported 2015-06-14 10:27:19 PDT
[ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Attachments
Patch (78.19 KB, patch)
2015-06-14 11:43 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-06-14 11:43:13 PDT
Created attachment 254862 [details] Patch
Darin Adler
Comment 2 2015-06-15 10:47:32 PDT
Comment on attachment 254862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254862&action=review > Source/JavaScriptCore/runtime/IteratorPrototype.cpp:38 > +namespace JSC { > + > +} Not sure what this is; but should probably remove it.
Yusuke Suzuki
Comment 3 2015-06-15 10:50:27 PDT
Comment on attachment 254862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254862&action=review Thanks! >> Source/JavaScriptCore/runtime/IteratorPrototype.cpp:38 >> +} > > Not sure what this is; but should probably remove it. OK, dropped :D. This block is originally introduced for definining forward declaration for XXX.prototype.xxx methods. (like `static EncodedJSValue JSC_HOST_CALL arrayIteratorProtoFuncIterator(ExecState*);`)
Yusuke Suzuki
Comment 4 2015-06-15 19:12:26 PDT
Committed r185577: <http://trac.webkit.org/changeset/185577>
Note You need to log in before you can comment on or make changes to this bug.