Bug 145963

Summary: [ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, darin, fpizlo, ggaren, kling, mark.lam, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Yusuke Suzuki 2015-06-14 10:27:19 PDT
[ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Comment 1 Yusuke Suzuki 2015-06-14 11:43:13 PDT
Created attachment 254862 [details]
Patch
Comment 2 Darin Adler 2015-06-15 10:47:32 PDT
Comment on attachment 254862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254862&action=review

> Source/JavaScriptCore/runtime/IteratorPrototype.cpp:38
> +namespace JSC {
> +
> +}

Not sure what this is; but should probably remove it.
Comment 3 Yusuke Suzuki 2015-06-15 10:50:27 PDT
Comment on attachment 254862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254862&action=review

Thanks!

>> Source/JavaScriptCore/runtime/IteratorPrototype.cpp:38
>> +}
> 
> Not sure what this is; but should probably remove it.

OK, dropped :D.
This block is originally introduced for definining forward declaration for XXX.prototype.xxx methods. (like `static EncodedJSValue JSC_HOST_CALL arrayIteratorProtoFuncIterator(ExecState*);`)
Comment 4 Yusuke Suzuki 2015-06-15 19:12:26 PDT
Committed r185577: <http://trac.webkit.org/changeset/185577>