Bug 145949

Summary:

AX:ARIA Toggle buttons aren't properly conveyed on iOS using VoiceOver

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
patch	darin: review+

chris fleizach

Reported 2015-06-12 16:59:00 PDT

We need to expose some attributes to the platform API to decide if an element has a pressed state.

Attachments
patch (4.06 KB, patch) 2015-06-12 17:00 PDT, chris fleizach	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (673.13 KB, application/zip) 2015-06-12 17:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (577.02 KB, application/zip) 2015-06-12 17:39 PDT, Build Bot	no flags	Details
patch (6.66 KB, patch) 2015-06-12 18:07 PDT, chris fleizach	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2015-06-12 16:59:15 PDT

<rdar://problem/19073512>

chris fleizach

Comment 2 2015-06-12 17:00:59 PDT

Created attachment 254835 [details] patch

Build Bot

Comment 3 2015-06-12 17:36:00 PDT

Comment on attachment 254835 [details] patch Attachment 254835 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6203648069599232 New failing tests: inspector-protocol/dom/getAccessibilityPropertiesForNode.html

Build Bot

Comment 4 2015-06-12 17:36:04 PDT

Created attachment 254838 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-06-12 17:39:55 PDT

Comment on attachment 254835 [details] patch Attachment 254835 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5791548105031680 New failing tests: inspector-protocol/dom/getAccessibilityPropertiesForNode.html

Build Bot

Comment 6 2015-06-12 17:39:59 PDT

Created attachment 254839 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

chris fleizach

Comment 7 2015-06-12 18:06:00 PDT

*** Bug 129830 has been marked as a duplicate of this bug. ***

chris fleizach

Comment 8 2015-06-12 18:07:56 PDT

Created attachment 254842 [details] patch

Darin Adler

Comment 9 2015-06-12 18:41:35 PDT

Comment on attachment 254842 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=254842&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2221 > + if (equalIgnoringCase(expanded, "true") || equalIgnoringCase(expanded, "false")) > + return true; > + return false; Should just be: return equalIgnoringCase(expanded, "true") || equalIgnoringCase(expanded, "false");

James Craig

Comment 10 2019-09-26 11:52:20 PDT

Chris, rdar://19073512 was resolved in 2015. Anything left to do here?

chris fleizach

Comment 11 2019-09-26 11:54:46 PDT

(In reply to James Craig from comment #10) > Chris, rdar://19073512 was resolved in 2015. Anything left to do here? ha, what happened with this bug. yea it looks like there's code that solves this, but not from this patch directly.

Note You need to log in before you can comment on or make changes to this bug.