Bug 145946

Summary:

Add private API to force page to always run at foreground priority

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebKit2

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	andersca: review+
Patch for EWS	commit-queue: commit-queue-

Description Gavin Barraclough 2015-06-12 15:54:02 PDT

Useful for offscreen loading.

Comment 1 Gavin Barraclough 2015-06-12 15:57:54 PDT

Created attachment 254831 [details]
Fix

Comment 2 Anders Carlsson 2015-06-12 17:14:14 PDT

Comment on attachment 254831 [details]
Fix

Isn't this iOS only? If so, it should be inside the PLATFORM(IOS) section below (and the TARGET_IOS_IPHONE section in the header).

Comment 3 Anders Carlsson 2015-06-12 17:14:30 PDT

Also, WK_MAC_TBA should be NA.

Comment 4 Gavin Barraclough 2015-06-12 19:05:51 PDT

Created attachment 254847 [details]
Patch for EWS

Comment 5 WebKit Commit Bot 2015-06-13 11:46:41 PDT

Comment on attachment 254847 [details]
Patch for EWS

Rejecting attachment 254847 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 254847, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Anders Carlson found in /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5723490053259264

Comment 6 Gavin Barraclough 2015-06-13 17:25:31 PDT

Transmitting file data ......
Committed revision 185541.