| Summary: | Fix missing braces and deprecated declarations warnings in WebKitNotificationProvider.cpp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | berto, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 145121 | ||||||
| Attachments: |
|
||||||
Created attachment 255111 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 255111 [details] Patch Clearing flags on attachment: 255111 Committed r185700: <http://trac.webkit.org/changeset/185700> All reviewed patches have been landed. Closing bug. Got to say, I'm amazed that code was legal.... |
../../Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:75:9: warning: suggest braces around initialization of subobject [-Wmissing-braces] kWKNotificationProviderCurrentVersion, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:75:9: warning: 'kWKNotificationProviderCurrentVersion' is deprecated: Use an explicit version number instead [-Wdeprecated-declarations] ../../Source/WebKit2/UIProcess/API/C/WKNotificationProvider.h:61:8: note: 'kWKNotificationProviderCurrentVersion' has been explicitly marked deprecated here enum { kWKNotificationProviderCurrentVersion __attribute__((deprecated("Use an explicit version number instead"))) = 0, }; ^ 2 warnings generated.