| Summary: | Add the remaining missing override specifiers under Source/WebCore/ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2015-06-11 23:22:11 PDT
Created attachment 254779 [details]
Patch
Comment on attachment 254779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254779&action=review > Source/WebCore/ChangeLog:13 > + Where the addition had to be performed on all virtual methods of the > + class, the virtual specifier was removed so now only the override > + specifier is in use. Still a bit controversial, but Antti did suggest this and nobody said no! > Source/WebCore/ChangeLog:22 > + (WebCore::EqualPowerPanner::reset): Deleted. I understand that the prepare change log script generated all of these, but please remove them. I don’t think it does anyone any good to list all these functions as deleted in the change log. Comment on attachment 254779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254779&action=review >> Source/WebCore/ChangeLog:22 >> + (WebCore::EqualPowerPanner::reset): Deleted. > > I understand that the prepare change log script generated all of these, but please remove them. I don’t think it does anyone any good to list all these functions as deleted in the change log. Will do. Committed r185518: <http://trac.webkit.org/changeset/185518> |