Bug 145895

Summary: Full screen video space can be resized to 1pt wide
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch simon.fraser: review+

Brent Fulgham
Reported 2015-06-11 13:23:12 PDT
In tiled mode, you can resize the full-screen video WebView to 1pt wide. This should not be possible.
Attachments
Patch (2.86 KB, patch)
2015-06-11 13:28 PDT, Brent Fulgham 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-06-11 13:23:34 PDT
<rdar://problem/20907914>
Brent Fulgham
Comment 2 2015-06-11 13:28:24 PDT
Created attachment 254753 [details] Patch
Brent Fulgham
Comment 3 2015-06-11 13:29:48 PDT
Related: <rdar://problem/21150721>
Brent Fulgham
Comment 4 2015-06-11 14:06:54 PDT
Committed r185473: <http://trac.webkit.org/changeset/185473>
Tim Horton
Comment 5 2015-08-16 17:59:58 PDT
Whaaa. This should not be using kWKLayoutModeDynamicSizeWithMinimumViewSize (nothing should! I just got here because I was about to delete it). Probably wanted the default, kWKLayoutModeViewSize. But also, you always reset to kWKLayoutModeViewSize, ignoring whatever it was before! I bet there's a lot of brokenness going into/out of fullscreen with a page that is scaled-down in Split View.
Tim Horton
Comment 6 2015-08-16 18:01:10 PDT
It's nontrivial to internally swap to a different layout mode and still come back to the right thing (respecting changes that come in from API clients, etc.), but I just implemented this for PDF, so we can probably reuse that.
Tim Horton
Comment 7 2015-08-16 18:01:10 PDT
It's nontrivial to internally swap to a different layout mode and still come back to the right thing (respecting changes that come in from API clients, etc.), but I just implemented this for PDF, so we can probably reuse that.
Tim Horton
Comment 8 2015-08-27 18:39:06 PDT
Patch to move to the better thing: https://bugs.webkit.org/show_bug.cgi?id=148553
Note You need to log in before you can comment on or make changes to this bug.