Bug 145824

Summary: MediaControls: Reenable resize of controls on pinch zoom
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Dean Jackson
Reported 2015-06-09 16:29:54 PDT
MediaControls: Reenable resize of controls on pinch zoom
Attachments
Patch (4.79 KB, patch)
2015-06-09 16:33 PDT, Dean Jackson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.
Dean Jackson
Comment 1 2015-06-09 16:30:12 PDT
<rdar://problem/21212778>
Dean Jackson
Comment 2 2015-06-09 16:33:14 PDT
Created attachment 254614 [details] Patch
Darin Adler
Comment 3 2015-06-09 16:40:47 PDT
Comment on attachment 254614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631 > + if (newScaleFactor) { Early return maybe to not nest this entire thing. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640 > + this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%"; Why ceil rather than round?
Dean Jackson
Comment 4 2015-06-09 17:53:25 PDT
Comment on attachment 254614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review >> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631 >> + if (newScaleFactor) { > > Early return maybe to not nest this entire thing. Done. >> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640 >> + this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%"; > > Why ceil rather than round? We got a few complaints about the bar not quite covering the media do to rounding down. But I'm going to go back to round to see what happens.
Dean Jackson
Comment 5 2015-06-09 17:54:04 PDT
Committed r185397: <http://trac.webkit.org/changeset/185397>
Dean Jackson
Comment 6 2015-06-09 17:54:19 PDT
Committed r185397: <http://trac.webkit.org/changeset/185397>