| Summary: | MediaControls: Reenable resize of controls on pinch zoom | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2015-06-09 16:29:54 PDT
Created attachment 254614 [details]
Patch
Comment on attachment 254614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631 > + if (newScaleFactor) { Early return maybe to not nest this entire thing. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640 > + this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%"; Why ceil rather than round? Comment on attachment 254614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review >> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631 >> + if (newScaleFactor) { > > Early return maybe to not nest this entire thing. Done. >> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640 >> + this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%"; > > Why ceil rather than round? We got a few complaints about the bar not quite covering the media do to rounding down. But I'm going to go back to round to see what happens. Committed r185397: <http://trac.webkit.org/changeset/185397> Committed r185397: <http://trac.webkit.org/changeset/185397> |