Bug 145810

Summary: Web Inspector: Unable to select parent element in the DOM tree path bar
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=145807
Attachments:
Description Flags
Animated GIF of the problem
none
Animated GIF with the patch applied
none
Patch none

Nikita Vasilyev
Reported 2015-06-09 12:17:39 PDT
Created attachment 254587 [details] Animated GIF of the problem My main use case for the DOM tree path bar is to select several levels up of the currently selected node. This works in Chrome DevTools and Firefox DevTools but not in Web Inspector. I don’t find the dropdown menu useful and I’d rather remove it completely.
Attachments
Animated GIF of the problem (74.08 KB, image/gif)
2015-06-09 12:17 PDT, Nikita Vasilyev 		no flags
Details
Animated GIF with the patch applied (109.59 KB, image/gif)
2015-06-19 22:05 PDT, Nikita Vasilyev 		no flags
Details
Patch (3.49 KB, patch)
2015-06-19 22:11 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-09 12:18:25 PDT
<rdar://problem/21305418>
Radar WebKit Bug Importer
Comment 2 2015-06-09 12:18:29 PDT
<rdar://problem/21305423>
Timothy Hatcher
Comment 3 2015-06-18 12:57:07 PDT
I think we should keep the popup. We just need a way to select a selected item in a <select>.
Nikita Vasilyev
Comment 4 2015-06-19 22:05:38 PDT
Created attachment 255276 [details] Animated GIF with the patch applied (In reply to comment #3) > I think we should keep the popup. We just need a way to select a selected > item in a <select>. Okay.
Nikita Vasilyev
Comment 5 2015-06-19 22:11:26 PDT
Created attachment 255277 [details] Patch
Timothy Hatcher
Comment 6 2015-06-20 10:28:43 PDT
Comment on attachment 255277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255277&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:126 > + pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.Clicked, this._pathComponentSelected, this); Does selecting a sibling still work?
Nikita Vasilyev
Comment 7 2015-06-20 14:59:30 PDT
(In reply to comment #6) > Comment on attachment 255277 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255277&action=review > > > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:126 > > + pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.Clicked, this._pathComponentSelected, this); > > Does selecting a sibling still work? Yes, it does.
WebKit Commit Bot
Comment 8 2015-06-20 15:48:24 PDT
Comment on attachment 255277 [details] Patch Clearing flags on attachment: 255277 Committed r185800: <http://trac.webkit.org/changeset/185800>
WebKit Commit Bot
Comment 9 2015-06-20 15:48:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.