Bug 145810 - Web Inspector: Unable to select parent element in the DOM tree path bar
Summary: Web Inspector: Unable to select parent element in the DOM tree path bar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-09 12:17 PDT by Nikita Vasilyev
Modified: 2015-06-20 15:48 PDT (History)
8 users (show)

See Also:

Attachments
Animated GIF of the problem (74.08 KB, image/gif)
2015-06-09 12:17 PDT, Nikita Vasilyev 		no flags Details
Animated GIF with the patch applied (109.59 KB, image/gif)
2015-06-19 22:05 PDT, Nikita Vasilyev 		no flags Details
Patch (3.49 KB, patch)
2015-06-19 22:11 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-06-09 12:17:39 PDT 
Created attachment 254587 [details]
Animated GIF of the problem

My main use case for the DOM tree path bar is to select several levels up of the currently selected node. This works in Chrome DevTools and Firefox DevTools but not in Web Inspector.

I don’t find the dropdown menu useful and I’d rather remove it completely.
Comment 1 Radar WebKit Bug Importer 2015-06-09 12:18:25 PDT 
<rdar://problem/21305418>
Comment 2 Radar WebKit Bug Importer 2015-06-09 12:18:29 PDT 
<rdar://problem/21305423>
Comment 3 Timothy Hatcher 2015-06-18 12:57:07 PDT 
I think we should keep the popup. We just need a way to select a selected item in a <select>.
Comment 4 Nikita Vasilyev 2015-06-19 22:05:38 PDT 
Created attachment 255276 [details]
Animated GIF with the patch applied

(In reply to comment #3)
> I think we should keep the popup. We just need a way to select a selected
> item in a <select>.

Okay.
Comment 5 Nikita Vasilyev 2015-06-19 22:11:26 PDT 
Created attachment 255277 [details]
Patch
Comment 6 Timothy Hatcher 2015-06-20 10:28:43 PDT 
Comment on attachment 255277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255277&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:126
> +            pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.Clicked, this._pathComponentSelected, this);

Does selecting a sibling still work?
Comment 7 Nikita Vasilyev 2015-06-20 14:59:30 PDT 
(In reply to comment #6)
> Comment on attachment 255277 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255277&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:126
> > +            pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.Clicked, this._pathComponentSelected, this);
> 
> Does selecting a sibling still work?

Yes, it does.
Comment 8 WebKit Commit Bot 2015-06-20 15:48:24 PDT 
Comment on attachment 255277 [details]
Patch

Clearing flags on attachment: 255277

Committed r185800: <http://trac.webkit.org/changeset/185800>
Comment 9 WebKit Commit Bot 2015-06-20 15:48:28 PDT 
All reviewed patches have been landed.  Closing bug.