[GTK] Allow to dispatch tasks in WorkQueue with different priorities

• Component: Web Template Framework
• Status: RESOLVED LATER

[Carlos Garcia Campos]

In glib we can use different priorities for the sources in the same main loop. I want to use this to give more priority to read tasks in the disk cache IO WorkQueue, but it could be useful for other cases as well.

[Carlos Garcia Campos]

Created attachment 254554 [details]
Patch

[WebKit Commit Bot]

Attachment 254554 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/WorkQueue.h:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:78:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:130:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:133:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Catanzaro]

In the test case, why name the nonmember variables with the m_ prefix?

[Carlos Garcia Campos]

(In reply to comment #3)
> In the test case, why name the nonmember variables with the m_ prefix?

Good question, there's no reason other than I copy-pasted from Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp :-P

[Carlos Garcia Campos]

We are no longer using this for the disk cache, so I guess we don't really need it for now.

[Zan Dobersek]

RESOLVED LATER?

[Zan Dobersek]

RESOLVED LATER.