| Summary: | Missing content in UIWebView snapshots sometimes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | koivisto, simon.fraser | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2015-06-08 17:31:55 PDT
Created attachment 254528 [details]
Patch
Comment on attachment 254528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254528&action=review > Source/WebCore/platform/ios/LegacyTileLayer.mm:35 > +using namespace WebCore; If we are going to add this, then are we going to remove all the other WebCore prefixes in this file? Maybe we should just use WebCore::FloatRect in the one place it matters. > Source/WebCore/platform/ios/LegacyTileLayer.mm:62 > + _tileGrid->tileCache().setOverrideVisibleRect(Optional<FloatRect>(dirtyRect)); I think just FloatRect(dirtyRect) would be better here. > Source/WebCore/platform/ios/LegacyTileLayer.mm:67 > + _tileGrid->tileCache().setOverrideVisibleRect(Optional<FloatRect>()); Nullopt is the normal way to write this. |