Bug 145764

Summary:

run-benchmark should either checkout JetStream 1.0.1 or support running the latest version

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, dewei_zhu, fpizlo, glenn

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

145762

Attachments:

Description	Flags
Fixes the bug	none

Description Ryosuke Niwa 2015-06-08 12:48:57 PDT

run-benchmark currently hard-codes 1.0.1 in its plan for JetStream and expects the ToT WebKit checkout to produce this version.

We need to either download 1.0.1 or support running the latest version.

It's probably preferable to download 1.0.1 since we want to able to control when change the benchmark we run.

Comment 1 Filip Pizlo 2015-06-08 12:50:44 PDT

Let's change it to check out 1.0.1.  We should only have the perf dashboard rev-up to the latest version of the benchmark when we are ready.  We don't want the dashboard to have a meaningless jitter every time someone makes an incremental change to a benchmark.

Comment 2 Ryosuke Niwa 2015-06-08 13:40:35 PDT

Okay, let me write a patch to do that.

Comment 3 Ryosuke Niwa 2015-06-08 14:31:56 PDT

Created attachment 254509 [details]
Fixes the bug

Comment 4 Darin Adler 2015-06-09 11:40:44 PDT

Comment on attachment 254509 [details]
Fixes the bug

rs=me

Comment 5 WebKit Commit Bot 2015-06-09 12:30:03 PDT

Comment on attachment 254509 [details]
Fixes the bug

Clearing flags on attachment: 254509

Committed r185371: <http://trac.webkit.org/changeset/185371>

Comment 6 WebKit Commit Bot 2015-06-09 12:30:07 PDT

All reviewed patches have been landed.  Closing bug.