| Summary: | Fix unused private field warning in GraphicsLayerUpdater.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 145121 | ||||||
| Attachments: |
|
||||||
Created attachment 254490 [details]
Patch
Comment on attachment 254490 [details]
Patch
Is there any way to do this more elegantly and thoroughly? I’m not sure what the value is of having a virtual destructor and a boolean when USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.
Comment on attachment 254490 [details] Patch Clearing flags on attachment: 254490 Committed r185372: <http://trac.webkit.org/changeset/185372> All reviewed patches have been landed. Closing bug. |
clang build log: ----------------- In file included from ../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:27: ../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.h:66:33: warning: private field 'm_client' is not used [-Wunused-private-field] GraphicsLayerUpdaterClient& m_client; m_client is only used if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true. But it is true only on Cocoa platform. Let's guard this member properly.