Bug 145739

Summary: Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Before Patch is applied
none
After Patch is applied
none
[Animated GIF] opacity vs hsla none

Brian Burg
Reported 2015-06-07 14:20:19 PDT
To match what's done in the console.
Attachments
Patch (1.50 KB, patch)
2015-06-29 16:05 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2015-06-30 17:06 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Before Patch is applied (24.87 KB, image/png)
2015-06-30 17:08 PDT, Devin Rousso 		no flags
Details
After Patch is applied (35.93 KB, image/png)
2015-06-30 17:08 PDT, Devin Rousso 		no flags
Details
[Animated GIF] opacity vs hsla (3.42 KB, image/gif)
2015-06-30 22:56 PDT, Nikita Vasilyev 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-07 14:20:45 PDT
<rdar://problem/21277790>
Devin Rousso
Comment 2 2015-06-29 16:05:16 PDT
Created attachment 255789 [details] Patch
Joseph Pecoraro
Comment 3 2015-06-29 16:33:13 PDT
Comment on attachment 255789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78 > +.dom-tree-outline li.selected > span::after { > + content: " = $0"; > + opacity: 0.5; > +} The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint?
Timothy Hatcher
Comment 4 2015-06-30 09:34:29 PDT
Comment on attachment 255789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78 >> +} > > The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint? I agree.
Brian Burg
Comment 5 2015-06-30 09:53:10 PDT
Comment on attachment 255789 [details] Patch r=me Please adjust the colors per Joe's comment, and attach before/after screenshots to this bug.
Devin Rousso
Comment 6 2015-06-30 17:06:03 PDT
Created attachment 255877 [details] Patch
Devin Rousso
Comment 7 2015-06-30 17:08:03 PDT
Created attachment 255878 [details] Before Patch is applied
Devin Rousso
Comment 8 2015-06-30 17:08:18 PDT
Created attachment 255879 [details] After Patch is applied
WebKit Commit Bot
Comment 9 2015-06-30 19:08:34 PDT
Comment on attachment 255877 [details] Patch Clearing flags on attachment: 255877 Committed r186163: <http://trac.webkit.org/changeset/186163>
WebKit Commit Bot
Comment 10 2015-06-30 19:08:39 PDT
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 11 2015-06-30 22:56:10 PDT
Created attachment 255901 [details] [Animated GIF] opacity vs hsla It's important to use rgba/hsla over opacity, as the latter disables subpixel anti-aliasing. The committed change uses opacity.
Timothy Hatcher
Comment 12 2015-07-01 10:23:09 PDT
(In reply to comment #11) > Created attachment 255901 [details] > [Animated GIF] opacity vs hsla > > It's important to use rgba/hsla over opacity, as the latter disables > subpixel anti-aliasing. The committed change uses opacity. Good point. Lets fix that. rs=me
Note You need to log in before you can comment on or make changes to this bug.