Bug 145739

Summary: Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Before Patch is applied
none
After Patch is applied
none
[Animated GIF] opacity vs hsla none

Description Brian Burg 2015-06-07 14:20:19 PDT
To match what's done in the console.
Comment 1 Radar WebKit Bug Importer 2015-06-07 14:20:45 PDT
<rdar://problem/21277790>
Comment 2 Devin Rousso 2015-06-29 16:05:16 PDT
Created attachment 255789 [details]
Patch
Comment 3 Joseph Pecoraro 2015-06-29 16:33:13 PDT
Comment on attachment 255789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78
> +.dom-tree-outline li.selected > span::after {
> +    content: " = $0";
> +    opacity: 0.5;
> +}

The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint?
Comment 4 Timothy Hatcher 2015-06-30 09:34:29 PDT
Comment on attachment 255789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review

>> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78
>> +}
> 
> The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint?

I agree.
Comment 5 Brian Burg 2015-06-30 09:53:10 PDT
Comment on attachment 255789 [details]
Patch

r=me

Please adjust the colors per Joe's comment, and attach before/after screenshots to this bug.
Comment 6 Devin Rousso 2015-06-30 17:06:03 PDT
Created attachment 255877 [details]
Patch
Comment 7 Devin Rousso 2015-06-30 17:08:03 PDT
Created attachment 255878 [details]
Before Patch is applied
Comment 8 Devin Rousso 2015-06-30 17:08:18 PDT
Created attachment 255879 [details]
After Patch is applied
Comment 9 WebKit Commit Bot 2015-06-30 19:08:34 PDT
Comment on attachment 255877 [details]
Patch

Clearing flags on attachment: 255877

Committed r186163: <http://trac.webkit.org/changeset/186163>
Comment 10 WebKit Commit Bot 2015-06-30 19:08:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Nikita Vasilyev 2015-06-30 22:56:10 PDT
Created attachment 255901 [details]
[Animated GIF] opacity vs hsla

It's important to use rgba/hsla over opacity, as the latter disables subpixel anti-aliasing. The committed change uses opacity.
Comment 12 Timothy Hatcher 2015-07-01 10:23:09 PDT
(In reply to comment #11)
> Created attachment 255901 [details]
> [Animated GIF] opacity vs hsla
> 
> It's important to use rgba/hsla over opacity, as the latter disables
> subpixel anti-aliasing. The committed change uses opacity.

Good point. Lets fix that. rs=me