Summary: | Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Brian Burg
2015-06-07 14:20:19 PDT
Created attachment 255789 [details]
Patch
Comment on attachment 255789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78 > +.dom-tree-outline li.selected > span::after { > + content: " = $0"; > + opacity: 0.5; > +} The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint? Comment on attachment 255789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78 >> +} > > The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint? I agree. Comment on attachment 255789 [details]
Patch
r=me
Please adjust the colors per Joe's comment, and attach before/after screenshots to this bug.
Created attachment 255877 [details]
Patch
Created attachment 255878 [details]
Before Patch is applied
Created attachment 255879 [details]
After Patch is applied
Comment on attachment 255877 [details] Patch Clearing flags on attachment: 255877 Committed r186163: <http://trac.webkit.org/changeset/186163> All reviewed patches have been landed. Closing bug. Created attachment 255901 [details]
[Animated GIF] opacity vs hsla
It's important to use rgba/hsla over opacity, as the latter disables subpixel anti-aliasing. The committed change uses opacity.
(In reply to comment #11) > Created attachment 255901 [details] > [Animated GIF] opacity vs hsla > > It's important to use rgba/hsla over opacity, as the latter disables > subpixel anti-aliasing. The committed change uses opacity. Good point. Lets fix that. rs=me |